Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Uno 5.x #311

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Update to Uno 5.x #311

merged 3 commits into from
Jan 24, 2024

Conversation

Arlodotexe
Copy link
Member

This PR aligns the submodule with CommunityToolkit/Tooling-Windows-Submodule#157

Closes #281.

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Jan 5, 2024

The CI is passing for the submodule, but when building the Wasm head locally, I'm getting errors such as

CSC : error UXAML0001: The type x:String could not be found [D:\source\uwp\lib\Windows\components\Converters\sam
       ples\Converters.Samples.csproj::TargetFramework=net7.0]

I've opened this PR early so we can see the errors in CI and iterate on this.

@MartinZikmund
Copy link
Contributor

@Arlodotexe I think this may fix all the issues, will try to get it merged asap unoplatform/uno#14985

@MartinZikmund
Copy link
Contributor

@Arlodotexe ok, so still more to do 😞, I will try again tomorrow!

@MartinZikmund
Copy link
Contributor

So one more fix coming in soon unoplatform/uno#15096 then we should be good hopefully

@Arlodotexe
Copy link
Member Author

@MartinZikmund Looks like Wasm produced an error in Uno.UI.SourceGenerators:

/home/runner/work/Windows/Windows/components/Converters/samples/Uno.UI.SourceGenerators/Uno.UI.SourceGenerators.XamlGenerator.XamlCodeGenerator/TypeToObjectConverterSample_eb40f77f5f3b6990326fe529231cbd10.cs(172,301): error CS0118: '___tctx' is a variable but is used like a type

@Arlodotexe
Copy link
Member Author

Found an issue after the Uno 5.0 update where the 'Overview' header is misplaced on WebAssembly:

image

This isn't the case on UWP:
image

Or on Wasdk:
image

Otherwise, no new issues with the components themselves.

@Arlodotexe Arlodotexe enabled auto-merge (rebase) January 24, 2024 22:03
@Arlodotexe Arlodotexe merged commit a484c67 into main Jan 24, 2024
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the upgrade/uno5.0 branch January 24, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add support for Uno Platform 5.x
3 participants