Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup project references #318

Merged
merged 10 commits into from
Jan 24, 2024
Merged

Cleanup project references #318

merged 10 commits into from
Jan 24, 2024

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Jan 20, 2024 •
edited
Loading

This PR:

  • Fixes WindowsAppSDK All-up Sample App no longer runs #212
  • Fixes all usages of relative ProjectReference paths to be relative to repo root
  • Fixes malformed references to ToolkitBehaviorsSourceProject and ToolkitExtensionsSourceProject
  • Fixed any source path prop names defined in Directory.Build.props that didn't match the component name

Prerequisite PR: CommunityToolkit/Tooling-Windows-Submodule#163

@Arlodotexe Arlodotexe self-assigned this Jan 20, 2024
This was referenced Jan 20, 2024
Merged
Merged
@Arlodotexe Arlodotexe enabled auto-merge (rebase) January 23, 2024 22:14
@Arlodotexe Arlodotexe merged commit da0f889 into main Jan 24, 2024
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cleanup/project-references branch January 24, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

Assignees

@Arlodotexe Arlodotexe

Labels
None yet
Projects
Toolkit 8.x
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WindowsAppSDK All-up Sample App no longer runs
2 participants
@Arlodotexe @michael-hawker