Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Implicit animations when running under Uno #326

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Disable Implicit animations when running under Uno #326

merged 3 commits into from
Jan 30, 2024

Conversation

Arlodotexe
Copy link
Member

Progress towards #319
Needed for #241
See also #241 (comment)

This PR disables calls to the Composition APIs in the Implicit animation attached property when running under Uno.

Arlodotexe
Arlodotexe commented Jan 29, 2024
View reviewed changes
Copy link
Member Author

@Arlodotexe Arlodotexe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to suppress CS0162 for disabled code

@Arlodotexe Arlodotexe self-assigned this Jan 29, 2024
@Arlodotexe Arlodotexe merged commit ea17664 into main Jan 30, 2024
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/uno/animations/implicit branch January 30, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

Assignees

@Arlodotexe Arlodotexe

Labels
None yet
Projects
Toolkit 8.x
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Arlodotexe @michael-hawker