[SettingsExpander] Fix CornerRadius bug #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-hawker
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Looks good, only concern would be that since converter is internal, if someone overwrites the style, they'd have to manually copy that as well to maintain the behavior. Trying to think if there's examples of internal converters in the SDK, but think usually there's just a sub-namespace, eh?
Was also noticing some of our other helpers are public, so not sure if that's a problem, though probably too late now if we want otherwise. Anyway, just notes for us for the future. 🙂
Arlodotexe
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Before (corner is blurred/lighter gray caused by the root grid overlapping with the border)
After (corner is sharp)
Fixes: #325