Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DockPanel.md #419

Merged
merged 1 commit into from
May 18, 2024
Merged

Update DockPanel.md #419

merged 1 commit into from
May 18, 2024

Conversation

mael8
Copy link
Contributor

@mael8 mael8 commented May 13, 2024

Fixes

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

Wrongly suggests to close Page tag in the "Syntax" section

What is the new behavior?

Don't close the Page tag before the DockPanel sample

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Documentation has been added
    • Sample in sample app has been added
    • Analyzers are passing for documentation and samples
    • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
  • Tests for the changes have been added (if applicable)
  • Header has been added to all new source files
  • Contains NO breaking changes

Other information

@mael8
Copy link
Contributor Author

mael8 commented May 13, 2024

@dotnet-policy-service agree

@Arlodotexe Arlodotexe enabled auto-merge (rebase) May 18, 2024 00:33
@Arlodotexe Arlodotexe merged commit 449cfea into CommunityToolkit:main May 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants