Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest stable WinAppSdk 1.4 #161

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

Arlodotexe
Copy link
Member

Closes #160 and upgrades our tooling to use the latest stable WinAppSdk 1.4. Any components with a dependency on Microsoft.Graphics.Win2D will need to be updated to the latest 1.1.1 right away, see below for details.

Additional notes

Here's what I've found:

  • The Extensions component (no win2d dependency) builds as expected with WinAppSdk 1.4.
  • The Animations component (only depends on Extensions, no Win2d) builds as expected with WinAppSdk 1.4.
  • The Media component (only depends on Animations and win2d) fails to build after updating to Wasdk 1.4 and depending on any version of Win2d (including the latest 1.1.1).
  • Upgrading the Wasdk TargetFrameworks to use windows10.0.22621.0 instead of windows10.0.19041.0 results in successful builds for the Media component under both the net6-* and net7-* tfm.

Regarding how this change affects targeting different versions of Windows for WinAppSdk:

  • Overall, this won't cause issues for targeting older versions of Windows, but it will require those who depend on our packages to upgrade their Tfm.
  • UWP and Uno are unaffected. Uno.UI and Uno.WinUI don't have a dependency on the Windows SDK, and we aren't targeting or compiling Uno for the Media package (since Uno doesn't support Win2d).
  • TargetPlatformMinVersion (17763) and TargetPlatformVersion (19041) are defined for both Uwp and Wasdk here.
  • Wasdk has SupportedOSPlatform defined here.
  • Microsoft.Graphics.Win2D fail to work with winui after 1.1.0 microsoft/Win2D#943: "Only the TargetFramework was updated to get the latest 22H2 improvements, the MinPlatformVersion is still 17763 to ensure that Win2D still runs downlevel."
  • Upgrade to v1.1.0 causes compiler error microsoft/Win2D#936 (comment): "You do not need to change your TargetPlatformMinVersion, that has not changed with the new Win2D release."

@Arlodotexe Arlodotexe added enhancement New feature or request dev loop ➰ For issues that impact the core dev-loop of building experiments nuget 📦 labels Dec 14, 2023
@Arlodotexe Arlodotexe self-assigned this Dec 14, 2023
@niels9001 niels9001 self-requested a review January 5, 2024 15:41
@michael-hawker michael-hawker merged commit 9665c46 into main Jan 9, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the targets/upgrade/wasdk/1.4 branch January 9, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev loop ➰ For issues that impact the core dev-loop of building experiments enhancement New feature or request nuget 📦
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade packages to WindowsAppSDK 1.4
2 participants