Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests with Behave #104

Merged
merged 15 commits into from
Jan 30, 2022
Merged

Add tests with Behave #104

merged 15 commits into from
Jan 30, 2022

Conversation

duhow
Copy link
Collaborator

@duhow duhow commented Jan 28, 2022 •
edited
Loading

Using Gherkin language, this should be easier to maintain and develop new tests.
Added some of the reported issues as a way to prevent regression.

@duhow duhow marked this pull request as ready for review January 28, 2022 17:49
@duhow duhow requested a review from Fubukimaru January 28, 2022 17:49
@duhow duhow marked this pull request as draft January 28, 2022 18:09
@duhow duhow marked this pull request as ready for review January 28, 2022 18:57
@duhow duhow mentioned this pull request Jan 30, 2022
Merged
@Fubukimaru
Copy link
Owner

Looks good, is this finished?

@duhow
Copy link
Collaborator Author

duhow commented Jan 30, 2022

Let me enable the new merged #106 before merging.

@duhow
Copy link
Collaborator Author

duhow commented Jan 30, 2022

All yours @Fubukimaru !

Fubukimaru
Fubukimaru approved these changes Jan 30, 2022
View reviewed changes
Copy link
Owner

@Fubukimaru Fubukimaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@Fubukimaru Fubukimaru merged commit 3dc68fa into master Jan 30, 2022
@duhow duhow deleted the test branch March 16, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fubukimaru Fubukimaru Fubukimaru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duhow @Fubukimaru