[TASK] Remove v:switch and v:case #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That woul mean vhs 3.0 - is there anything we can release upfront? |
|
That is exactly what that would mean :) We can make a bugfix release for 2.4.1 if necessary. |
|
We could also make class aliases. I'll do that! |
|
Alright - great idea! |
|
Are they 100% compatible argument-wise? |
Hmm, now that you mention it... they're not. We do have to remove these without aliases, and the migration description needs to include argument differences. |
|
Agreed. :) |
This removes the two now redundant ViewHelpers - every supported TYPO3 version now contains proper Switch/Case ViewHelpers. To migrate: * Identify all templates containing `v:switch` * Replace `v:switch` with `f:switch` * Use `expression` argument on `f:switch` (the `value` argument does not exist there) * Remove `as` argument (undocumented, no substitution) * Replace `v:case` with `f:case` * Special: if `v:case` with `case="default"` exists - replace with `default="1"` on `f:case` (or `f:defaultCase` without arguments if your minimum core version is TYPO3v8 and up) * Use `value` argument on `f:case` (the `case` argument does not exist there)
|
Someone shold mark the v:switch as DEPRECATED in the viewhelper reference at: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the two now redundant ViewHelpers - every supported TYPO3 version now contains proper Switch/Case ViewHelpers.
To migrate:
v:switchv:switchwithf:switchexpressionargument onf:switch(thevalueargument does not exist there)asargument (undocumented, no substitution)v:casewithf:casev:casewithcase="default"exists - replace withdefault="1"onf:case(orf:defaultCasewithout arguments if your minimum core version is TYPO3v8 and up)valueargument onf:case(thecaseargument does not exist there)