Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linux armv7l and win/osx arm64 builds #2113

Merged
merged 30 commits into from
Sep 6, 2022
Merged

Add linux armv7l and win/osx arm64 builds #2113

merged 30 commits into from
Sep 6, 2022

Conversation

Jai-JAP
Copy link
Contributor

@Jai-JAP Jai-JAP commented Mar 8, 2022 •
edited
Loading

Add linux armv7l and win/osx arm64 builds

Pull Request Type
Please select what type of pull request this is:

  • Bugfix
  • Feature Implementation

Related issue
Closes #2104

Description
Added linux armv7l to build.yml and release.yml
Added win/osx arm64 to _scripts/build.js, build.yml and release.yml
Linux armv7l and win/osx arm64 artifacts are automatically built with every commit & also releases with every FreeTube release

Screenshots (if appropriate)
Not applicable

Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested? No
Please describe shortly how you tested it and whether there are any ramifications remaining.
This PR has not been tested as workflows can't be run on forks

Desktop (please complete the following information):

  • OS: Linux armv7l / Windows arm64 / OSX arm64
  • OS Version: N/A
  • FreeTube version: N/A

@PrestonN PrestonN enabled auto-merge (squash) March 8, 2022 08:40
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 8, 2022
@Jai-JAP Jai-JAP mentioned this pull request Mar 8, 2022
Closed
2 tasks
auto-merge was automatically disabled March 8, 2022 09:38

Head branch was pushed to by a user without write access

@PrestonN PrestonN enabled auto-merge (squash) March 8, 2022 09:39
auto-merge was automatically disabled March 8, 2022 09:39

Head branch was pushed to by a user without write access

auto-merge was automatically disabled March 8, 2022 09:39

Head branch was pushed to by a user without write access

@PrestonN PrestonN enabled auto-merge (squash) March 8, 2022 09:39
auto-merge was automatically disabled March 8, 2022 10:48

Head branch was pushed to by a user without write access

@PrestonN PrestonN enabled auto-merge (squash) March 8, 2022 10:48
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

i think this also fixes #1372

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@PrestonN i think ur the only one that is able to test this because u have a pi

@Jai-JAP Jai-JAP changed the title Add linux armv7l to build.yml and release.yml Add linux armv7l and win/osx arm64 builds May 5, 2022
@Jai-JAP
Copy link
Contributor Author

Jai-JAP commented May 5, 2022

The upoming commits will add windows and macos arm64 builds to releases and every commit ci builds along with required fixes in _scripts/build.js

auto-merge was automatically disabled May 5, 2022 06:15

Head branch was pushed to by a user without write access

@PrestonN PrestonN enabled auto-merge (squash) May 5, 2022 06:15
@Jai-JAP
Copy link
Contributor Author

Jai-JAP commented May 5, 2022

this is now ready to merge @efb4f5ff-1298-471a-8973-3d47447115dc @PrestonN

@absidue absidue removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 31, 2022
@PikachuEXE
Copy link
Collaborator

I think I am done after this requested change
I can't test arm64 on windows / linux so I will rely on other reviewers / "production test"

@Jai-JAP @PikachuEXE
Update .github/workflows/release.yml
266ddaf 
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
auto-merge was automatically disabled June 27, 2022 07:57

Head branch was pushed to by a user without write access

@Jai-JAP @PikachuEXE
Update .github/workflows/build.yml
9af61bc 
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
@PrestonN PrestonN enabled auto-merge (squash) June 27, 2022 07:57
@Jai-JAP
Copy link
Contributor Author

Jai-JAP commented Jun 27, 2022

I think I am done after this requested change I can't test arm64 on windows / linux so I will rely on other reviewers / "production test"

Linux armv7l and arm64 are tested working. The only thing that needs tedting is win-arm64

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@Jai-JAP doesnt this also fix #1372?

@Jai-JAP
Copy link
Contributor Author

Jai-JAP commented Jun 28, 2022

I have seen this issue before...
That is an error caused by user not using correct steps for compiling and not an issue with freetube.

Seeing the log contents says that builder has downloaded fpm-linux-x64 on arm linux and hence cannot execute error

Closed
@Jai-JAP Jai-JAP mentioned this pull request Jul 10, 2022
Open
5 tasks
@PikachuEXE PikachuEXE mentioned this pull request Jul 20, 2022
Closed
1 task
@PikachuEXE PikachuEXE mentioned this pull request Aug 3, 2022
Merged
1 task
@Jai-JAP
Copy link
Contributor Author

Jai-JAP commented Aug 27, 2022

Any updates??

PikachuEXE
PikachuEXE approved these changes Aug 27, 2022
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only test MacOS but we know it GGed
Not sure if got people to test other 2...

@Jai-JAP
Copy link
Contributor Author

Jai-JAP commented Sep 4, 2022

I can only test MacOS but we know it GGed
Not sure if got people to test other 2...

I can test win-x64 and linux-all

@ChunkyProgrammer
Copy link
Member

i think the workflow passing is good enough for now as the team does not have the hardware to adequately test all of the new builds, if any issues arise from these builds then it's likely an issue caused by electron as the build workflow is passing

@PrestonN PrestonN merged commit ce77d16 into FreeTubeApp:development Sep 6, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 6, 2022
@absidue absidue mentioned this pull request Sep 10, 2022
Merged
1 task
@archisman-panigrahi
Copy link

archisman-panigrahi commented Sep 18, 2022 •
edited
Loading

I have an armhf Tablet running RPiOS. I can test this. Where are the build files for armhf?

@Jai-JAP
Copy link
Contributor Author

Jai-JAP commented Sep 18, 2022

https://github.com/FreeTubeApp/FreeTube/actions/runs/3003447109
You can download arm nightly builds here.

@archisman-panigrahi
Copy link

I can confirm that FreeTube works (I can watch videos, subscribe to channels and so on) on my Surface RT tablet running armhf version of Raspberry Pi OS. While the video is a bit choppy at 780p (the NVidia graphics of Surface RT is not yet supported on GNU/Linux), FreeTube works very well in 360p. At least, now I can peacefully use YouTube on this tablet.

Thank you all for the effort.
image

@Jai-JAP Jai-JAP deleted the patch-1 branch September 18, 2022 11:38
@archisman-panigrahi
Copy link

archisman-panigrahi commented Sep 21, 2022 •
edited
Loading

Is it possible to also enable arm32 builds for Windows? Then one can use the app in Surface RT (running Windows 8.1 RT)

The tablet ships with IE 11 (Edge is not available) and Youtube does not support this browser anymore. If FreeTube can be made available, that would be great.

@Jai-JAP
Copy link
Contributor Author

Jai-JAP commented Sep 21, 2022

No its not possible because nodejs doesn't support windows arm32 platform.

@theofficialgman theofficialgman mentioned this pull request Nov 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@PrestonN PrestonN Awaiting requested review from PrestonN

@absidue absidue Awaiting requested review from absidue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Freetube - Armhf
7 participants
@Jai-JAP @efb4f5ff-1298-471a-8973-3d47447115dc @absidue @PikachuEXE @ChunkyProgrammer @archisman-panigrahi @PrestonN