Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to run docker with or without pytest #161

Open
docsteveharris opened this issue Nov 29, 2022 · 1 comment
Open

Option to run docker with or without pytest #161

docsteveharris opened this issue Nov 29, 2022 · 1 comment

Comments

@docsteveharris
Copy link
Contributor

docsteveharris commented Nov 29, 2022

It would be useful to be able to write tests that will run depending on the context.
That is

  • tests that run against live data
  • tests that run against mock data

For now, I've just added the [test] suffix to the pip install command in the docker file for the API

# installs testing: useful for debugging
RUN pip install --no-cache-dir /app/api[test]
# without testing
#RUN pip install --no-cache-dir /app/api

But I think the Dockerfile should pick up an environment file and this might both affect the pip install step, and be used to select/filter the tests that run.

We should also think about running these tests during the docker build?
That way we would have some reassurance that dockerised version will work as expected.
It would be nice to also work toward an end-to-end test that checked the status of the front-end too (as per the original playwright work).

@docsteveharris
Copy link
Contributor Author

docsteveharris commented Nov 29, 2022

See 4f6aee2 for some early work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant