Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotype - Paypal #1920

Open
newhinton opened this issue Oct 26, 2024 · 14 comments
Open

Autotype - Paypal #1920

newhinton opened this issue Oct 26, 2024 · 14 comments
Labels
Milestone

Comments

@newhinton
Copy link

Describe the bug

Sorry to bother you again. It seems that specifically paypal does not work with keepass dx. I think it never worked since the main issue with autotype was fixed.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'https://www.paypal.com/signin'
  2. No autofill suggestion

Alternatively, the checkout process also does not work.

Expected behavior

The popup shows up.

KeePass Database

  • Created with: Keepass XC (I think)
  • Version: I dont remember
  • Location:
  • File provider (content:// URI):
  • Size:
  • Contains attachment:

KeePassDX:

  • Version: 4.08
  • Build: libre
  • Language: german

Android:

  • Device: Pixel 7
  • Version: 14/15

Additional context

I am not sure if this is even a bug. Recently i can't even paste the totp-code into its field from aegis via clipboard, i wouldn't be surprised if they actively tried to break autofill. Though i can't imagine why. Oh, and the used browser is firefox.

Thank you for looking into it if you so choose!

@newhinton newhinton added the bug label Oct 26, 2024
@J-Jamet
Copy link
Member

J-Jamet commented Nov 8, 2024

Not all two-screen forms work because the Autofill algorithm requires a password field to function. This will be solved when the algorithm takes into account the context of the page according to its URL, probably in a library.

@J-Jamet J-Jamet added this to the Autofill milestone Nov 8, 2024
@J-Jamet J-Jamet added this to To study Nov 8, 2024
@github-project-automation github-project-automation bot moved this to To Do in To study Nov 8, 2024
@cbiere
Copy link

cbiere commented Nov 20, 2024

This totally works for me in Firefox based browsers (Mull, Fennec, Firefox Beta). There's occasionally breakage with login forms forcing you to type in each TOTP digit separatedly but that's independent from KeePassDX and more depending on the browser and its settings (desktop mode, fingerprint protection, extensions etc.).

@cbiere
Copy link

cbiere commented Nov 25, 2024

Actually, since updating to 4.1.1 it doesn't work anymore. I didn't have this problem with 4.1.0 or 4.0.8.

@HyperCriSiS
Copy link

Autofill at general does not work quite often. Is this a known issue?
Many apps and many web site, even very popular ones like chatgpt.

@J-Jamet
Copy link
Member

J-Jamet commented Nov 25, 2024

Actually, since updating to 4.1.1 it doesn't work anymore. I didn't have this problem with 4.1.0 or 4.0.8.

The recognition algorithm hasn't been changed in 4.1.1, I've just tested it and it works well for forms with native browsers but not for browsers with compatibility, like before for paypal.
If you have other general autofill problems, there may be a problem with your device's autofill service.

@J-Jamet
Copy link
Member

J-Jamet commented Nov 25, 2024

And I repeat, for forms that require two screens, one for the username/email and the other for the passords, autofill will only work for the password screen because the algorithm doesn't know in advance that the second screen will contain a password.
This can be improved with a dictionary system, but it needs to be encapsulated in a dedicated library.

@cbiere
Copy link

cbiere commented Nov 25, 2024

Since newhinton mentioned Firefox, I tried this in Firefox, Firefox Beta, Fennec and Mull. The KeePassDX-Button appears as soon as I tap on the login field:
Screenshot_20241125-080931

What doesn't work anymore is the matching of the URL to the PayPal entry in the KeePass database.

I understand these are technically two separate issues. The issue description is a bit too vague which of the two or both it is.

@J-Jamet
Copy link
Member

J-Jamet commented Nov 25, 2024

URL matching works well for me, what URL do you have for Paypal in your entry?

@newhinton
Copy link
Author

I am using "https://www.paypal.com/signin"

This is how it looks for me:
Screenshot_20241125-083323

Above the numbers on the keyboard will be the button for keepass. (Though other keyboards have the same issue with different methods like the popup)

I am using fennec 132.0.0 currently

@cbiere
Copy link

cbiere commented Nov 25, 2024

The same URL that is mentioned in the issue description: https://www.paypal.com/signin

As I wrote in #1820 the algorithm now only seems to work if the path is absent from the URL. With just https://www.paypal.com it should work.

@newhinton
Copy link
Author

Though that issue seems to be about post-keyboard-popup detection. The problem i have is specificly that the popup doesn't show in the first place, so that subdomain matching is not relevant (or available, since the db is still locked)

I am honestly not even sure if this is a bug in keepassdx at all. It might be an issue somewhere else, because after @J-Jamet overhauled the autotype a couple of months ago, nearly all login types work for me again.

It is just specifically paypal (and my own unraid server) that dont work. Though sadly i don't really know enough about the autotype-service to start debugging this on .y own.

@cbiere
Copy link

cbiere commented Nov 25, 2024

@newhinton What keyboard do you use? I've been using Heliboard. At least in the past, the keyboard or the settings of it seemed to make a different because the suggestion strip seemed to overwrite the KeePassDX button and make it disappear.

Screenshot_20241125-084031

@newhinton
Copy link
Author

At the moment i am using https://github.com/florisboard/florisboard.

However, i only recently started using it. Before i used the grapheneos-default keyboard (which is probably very close to the aosp-default as you can get) and it had the same issue. (that one does not have a "key" for the passwords, but a popup-overlay directly in the content)

@cbiere
Copy link

cbiere commented Nov 25, 2024

I installed florisboard from F-Droid, didn't modify any settings and it works for me as well:
Screenshot_20241125-093055

By the way, it does even work in Chrome, after entering some nonsense in the username field and tapping the submit button. Once you get dropped back to the login form, the KeePassDX button appears. The same applies to many other websites with login forms that separate login and password fields (but not all).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To Do
Development

No branches or pull requests

4 participants