Try for a reproducer of a host code's build environment failure #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhornung67
reviewed
Sep 14, 2023
| namespace | ||
| { | ||
| // #if defined(AXOM_USE_UMPIRE) && defined(AXOM_USE_RAJA) && defined(AXOM_USE_CUDA) | ||
| #if defined(AXOM_USE_CUDA) && defined(AXOM_USE_CUDA) |
There was a problem hiding this comment.
Are you sure this code should be compiled if AXOM_USE_CUDA is defined or are you doubly sure? 😆
rhornung67
reviewed
Sep 15, 2023
| namespace | ||
| { | ||
| // #if defined(AXOM_USE_UMPIRE) && defined(AXOM_USE_RAJA) && defined(AXOM_USE_CUDA) | ||
| #if defined(AXOM_USE_CUDA) && defined(AXOM_USE_RAJA) |
|
I can't get it to build mfem yet, because hypre has a problem building. I'm sure I need to change the spack setup to properly point it to the system netlib-lapack. TPLs build when I use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The fixes all involve arrays of Point objects or arrays of objects that contain a Point.