Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error message of Update-Help when culture is C.UTF8 #19633

Closed
5 tasks done
adityapatwardhan opened this issue May 9, 2023 · 3 comments · Fixed by #19765
Closed
5 tasks done

Update error message of Update-Help when culture is C.UTF8 #19633

adityapatwardhan opened this issue May 9, 2023 · 3 comments · Fixed by #19765
Assignees
@adityapatwardhan
Labels
Issue-Enhancement the issue is more of a feature request than a bug Resolution-Fixed The issue is fixed. Up-for-Grabs Up-for-grabs issues are not high priorities, and may be opportunities for external contributors WG-Interactive-HelpSystem help infrastructure and formatting of help

Comments

@adityapatwardhan
Copy link
Member

adityapatwardhan commented May 9, 2023 •
edited
Loading

Prerequisites

Steps to reproduce

  1. Install Ubuntu20 with default culture (C.UTF8)
  2. Update-Help

For more details: #18037 (comment)
Related issue: #6217

Expected behavior

Error message saying "Your culture is C.UTF-8, which is a default not associated with any language, consider changing your system culture or install the English-US help content using: Update-Help -UICulture en-US."

Actual behavior

Update-Help: Failed to update Help for the module(s) 'Microsoft.PowerShell.Core' with UI culture(s) {C}:
Unable to retrieve the HelpInfo XML file for UI culture C.
Make sure the HelpInfoUri property in the module manifest is valid or check your network connection and then try the command again..
English-US help content is available and can be installed using: Update-Help -UICulture en-US.


### Error details

```console
NA

Environment data

Name                           Value
----                           -----
PSVersion                      7.3.4
PSEdition                      Core
GitCommitId                    7.3.4
OS                             Microsoft Windows 10.0.22621
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Visuals

NA
@adityapatwardhan adityapatwardhan added the Needs-Triage The issue is new and needs to be triaged by a work group. label May 9, 2023
@adityapatwardhan adityapatwardhan mentioned this issue May 9, 2023
Merged
22 tasks
@StevenBucher98 StevenBucher98 added WG-Interactive-HelpSystem help infrastructure and formatting of help Issue-Enhancement the issue is more of a feature request than a bug labels May 15, 2023
@daxian-dbw daxian-dbw added Up-for-Grabs Up-for-grabs issues are not high priorities, and may be opportunities for external contributors and removed Needs-Triage The issue is new and needs to be triaged by a work group. labels May 31, 2023
@adityapatwardhan
Copy link
Member Author

Updated expected error message as per WG discussion.

@josea
Copy link
Contributor

josea commented Jun 6, 2023

Hi,

I just tried this in my computer and while it doesn't seem to work correctly, it doesn't produce any error message at all (see image).

I was checking out the code, and it just looks to me that if there is no culture the foreach in line 521 of UpdatableHelpCommand.cs will just not enter but it won't throw any exceptions, so the call will just finish without doing anything at all.

Does it still show you the error?

image

@josea josea mentioned this issue Jun 7, 2023
Merged
22 tasks
@ghost ghost added the In-PR Indicates that a PR is out for the issue label Jun 20, 2023
@ghost ghost added Resolution-Fixed The issue is fixed. and removed In-PR Indicates that a PR is out for the issue labels Jun 20, 2023
@ghost
Copy link

ghost commented Jun 29, 2023

🎉This issue was addressed in #19765, which has now been successfully released as v7.4.0-preview.4.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adityapatwardhan adityapatwardhan

Labels
Issue-Enhancement the issue is more of a feature request than a bug Resolution-Fixed The issue is fixed. Up-for-Grabs Up-for-grabs issues are not high priorities, and may be opportunities for external contributors WG-Interactive-HelpSystem help infrastructure and formatting of help
Projects
None yet
Milestone
No milestone
4 participants
@daxian-dbw @josea @adityapatwardhan @StevenBucher98