Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slow execution when many breakpoints are used #14953

Merged
merged 8 commits into from
May 23, 2023
Merged

Fix slow execution when many breakpoints are used #14953

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
605905d
Improve PR
nohwnd Mar 7, 2021
644298d
Revert skipping empty breakpoint action
nohwnd Mar 7, 2021
e923885
Address build feedback
nohwnd Mar 7, 2021
7284188
Fix code factor issues
nohwnd Mar 7, 2021
ae921de
Fix code factor issues
nohwnd Mar 7, 2021
d5aa011
Address review feedback
nohwnd Mar 15, 2021
d8010bf
Make the field readonly
daxian-dbw May 22, 2023
fb816c2
Update debugger.cs
daxian-dbw May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix code factor issues
  • Loading branch information
@nohwnd @daxian-dbw
nohwnd authored and daxian-dbw committed May 22, 2023
commit ae921de469d49ffe72ca5438d31560178cb8d8f5
3 changes: 1 addition & 2 deletions src/System.Management.Automation/engine/debugger/debugger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1264,8 +1264,7 @@ private void AddPendingBreakpoint(LineBreakpoint breakpoint)
_pendingBreakpoints.AddOrUpdate(
breakpoint.Script,
new ConcurrentDictionary<int, LineBreakpoint> { [breakpoint.Id] = breakpoint },
daxian-dbw marked this conversation as resolved.
Show resolved Hide resolved
(_, dictionary) => { dictionary.TryAdd(breakpoint.Id, breakpoint); return dictionary; }
);
(_, dictionary) => { dictionary.TryAdd(breakpoint.Id, breakpoint); return dictionary; });
}

private void AddNewBreakpoint(Breakpoint breakpoint)
Expand Down