Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Update-Help throw proper error when current culture is not associated with a language #19765

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Make Update-Help throw proper error when current culture is not associated with a language #19765

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df3a79e
Add error message when trying to Update-Help in a Linux system with C…
josea Jun 20, 2023
25b32ff
Update src/System.Management.Automation/help/UpdateHelpCommand.cs
adityapatwardhan Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update src/System.Management.Automation/help/UpdateHelpCommand.cs
  • Loading branch information
@adityapatwardhan
adityapatwardhan committed Jun 20, 2023
commit 25b32ff3e86d048a68c319518a8bfd95080ea366
2 changes: 1 addition & 1 deletion src/System.Management.Automation/help/UpdateHelpCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ protected override void ProcessRecord()
{
string cultureString = string.IsNullOrEmpty(CultureInfo.CurrentCulture.Name) ? CultureInfo.CurrentCulture.DisplayName : CultureInfo.CurrentCulture.Name;
string errMsg = StringUtil.Format(HelpDisplayStrings.FailedToUpdateHelpWithLocaleNoUICulture, cultureString);
ErrorRecord error = new ErrorRecord(new InvalidOperationException(errMsg), "FailedToUpdateHelpWithLocaleNoUICulture", ErrorCategory.InvalidOperation, null);
ErrorRecord error = new ErrorRecord(new InvalidOperationException(errMsg), "FailedToUpdateHelpWithLocaleNoUICulture", ErrorCategory.InvalidOperation, targetObject: null);
ThrowTerminatingError(error);
}

Expand Down