stop corrupting memory in libpsl-native SetDate #6881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantraMSFT
approved these changes
May 17, 2018
3 tasks
iSazonov
reviewed
May 18, 2018
| return result; | ||
| } | ||
|
|
||
| return settimeofday(&tv, NULL); |
There was a problem hiding this comment.
Why do we use settimeofday if we don't use second parameter (timezone)?
Could we use stime? In the case we have to adjust only one parameter time_t.
Second question do this parameter adjustements work correctly for ARM reverse byte order?
There was a problem hiding this comment.
There are known issues there this isn't working on ARM. @dantraMSFT mentioned this to me.
Feel free to file an issue to switch to stime, although the better fix is probably to include the timezone. This fix is scoped to stop corrupting memory.
There was a problem hiding this comment.
Seems the timezone can be a issue too. We should look this in depth. Will push new Issue to discuss better solution.
|
LGTM to get this in Preview3. |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
stop corrupting memory in libpsl-native SetDate
Addresses #6872 - the first step
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests