Update _face_embedding.py #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey rajat, thanks for your contribution. I just had a brief look and looks solid to me. 💯 I'll check-it out and test it this weekend and then approve the pr. |
|
Hey Raj, while i looked into it, i found some more bugs. For this reason I made some bigger changes:
I'd be great if you could check the new implementation and if it works for you. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello,
i tried making some improvements in code,
File Operations: In
add_face, consider adding error handling for file operations (e.g., during saving/loading) to avoid crashes due to I/O issues.Face Detection: Ensure that the
detect_facesmethod gracefully handles cases where no faces are detected, returning an empty list instead of raising an unhandled exception.