Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compile warning due to default cast #2201

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Fixed compile warning due to default cast #2201

merged 1 commit into from
Oct 13, 2020

Conversation

fawdlstty
Copy link
Contributor

Fixed compile warning due to default cast

@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-io
Copy link

codecov-io commented Oct 13, 2020

Codecov Report

Merging #2201 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2201   +/-   ##
=======================================
  Coverage   86.47%   86.47%           
=======================================
  Files         511      511           
  Lines       83223    83223           
=======================================
  Hits        71971    71971           
  Misses      11252    11252           
Impacted Files Coverage Δ
src/layer/roialign.cpp 92.79% <100.00%> (ø)
src/layer/x86/roialign_x86.cpp 87.07% <100.00%> (ø)
src/mat_pixel_affine.cpp 96.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc24712...195a4dd. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Oct 13, 2020

This pull request fixes 2 alerts when merging 195a4dd into bc24712 - view on LGTM.com

fixed alerts:

  • 2 for Declaration hides parameter

@nihui nihui merged commit 1d1cb29 into Tencent:master Oct 13, 2020
@nihui
Copy link
Member

nihui commented Oct 13, 2020

Thanks for your contribution !

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.47%. Comparing base (bc24712) to head (195a4dd).
Report is 1649 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2201   +/-   ##
=======================================
  Coverage   86.47%   86.47%           
=======================================
  Files         511      511           
  Lines       83223    83223           
=======================================
  Hits        71971    71971           
  Misses      11252    11252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants