-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MathML <mroot>: clamp RadicalKernBefore/AfterDegree
https://bugs.webkit.org/show_bug.cgi?id=276427 Reviewed by Rob Buis. Implements the clamping described in MathML Core. See https://w3c.github.io/mathml-core/#root-with-index * LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/radic3als/root-parameters-2-expected.txt: This test passes. * LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/not-participating-to-parent-layout-expected.txt: tweak the failure message. * LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/width-height-001-expected.txt: ditto. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/width-height-001-expected.txt: ditto. * LayoutTests/platform/glib/mathml/presentation/roots-expected.txt: update render tree expectation. * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/not-participating-to-parent-layout-expected.txt: tweak the failure message. * LayoutTests/platform/ios/mathml/presentation/roots-expected.txt: update render tree expectation. * LayoutTests/platform/mac/mathml/presentation/roots-expected.txt: update render tree expectation. * Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::horizontalParameters): add a indexWidth parameter and perform the clamping fromt the spec. (WebCore::RenderMathMLRoot::computePreferredLogicalWidths): pass the preferred width of the index to the helper. (WebCore::RenderMathMLRoot::layoutBlock): pass the width of the index to the helper. (WebCore::RenderMathMLRoot::paint): ditto. * Source/WebCore/rendering/mathml/RenderMathMLRoot.h: add indexWidth parameter too. Canonical link: https://commits.webkit.org/280902@main
- Loading branch information
Showing
10 changed files
with
180 additions
and
175 deletions.
There are no files selected for viewing
4 changes: 2 additions & 2 deletions
4
...w3c/web-platform-tests/mathml/presentation-markup/radicals/root-parameters-2-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
|
||
FAIL RadicalKernBeforeDegree = -1em < 0 assert_approx_equals: should be clamped to 0 expected 0 +/- 1 but got -10 | ||
FAIL RadicalKernBeforeAfterDegree = -5em < -3em = -degree's inline size assert_approx_equals: should be clamped to 3em expected 30 +/- 1 but got 50 | ||
PASS RadicalKernBeforeDegree = -1em < 0 | ||
PASS RadicalKernBeforeAfterDegree = -5em < -3em = -degree's inline size | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.