Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pedal symbols render from Leland when using Finale Maestro music font #17885

Closed
XiaoMigros opened this issue Jun 6, 2023 · 6 comments · Fixed by #20934
Closed

Pedal symbols render from Leland when using Finale Maestro music font #17885

XiaoMigros opened this issue Jun 6, 2023 · 6 comments · Fixed by #20934
Assignees
Labels
engraving P2 Priority: Medium

Comments

@XiaoMigros
Copy link
Contributor

Issue type

Engraving bug

Bug description

The keyboard pedal symbols (Ped. and *) use Leland instead of Finale Maestro. No other fonts (including Finale Broadway) have this issue.

Steps to reproduce

  1. Create a new score
  2. Add a pedal marking, make note of how it looks
  3. In the style window, set the musical symbols font to Finale Maestro
  4. No change

Screenshots/Screen recordings

No response

MuseScore Version

4.0.2

Regression

No.

Operating system

Windows 10

Additional context

No response

@XiaoMigros XiaoMigros changed the title Pedal symbols render from Leland when using Finale Maestro Music Font Pedal symbols render from Leland when using Finale Maestro music font Jun 6, 2023
@Jojo-Schmitz
Copy link
Contributor

Some images to confirm, Bravura:
Ped-Bravura
Leland:
Ped-Leland
Finale Maestro:
Ped-Maestro

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Jun 7, 2023

But that seems by design, seems Maestro Text (!) doesn't have that glyph, so falls back to Leland Text:

        fontProvider->insertSubstitution(u"Finale Maestro Text", u"Leland Text");

That in turn would fall back to Bravura Text for missing glyphs, but doesn't need to here.

For the Musical Fonts though (those without "Text" in the name) the fallback is always Bravura, apparently.
Seems inconsistent to me, but is a different issue.

Check yourself: change only the text font and see the "Ped" changing

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Jun 7, 2023

Strangly for Pedal lines the Musical Text Font is used, but for Ottavas the Musical Font is used, that seems pretty inconsistent, doesn't it?
Mu3 used the Musical Text fonts for both, so this seems to be a regression

@XiaoMigros
Copy link
Contributor Author

That would explain why 8va works in Mu4 but not Mu3, do you think it's fair to mark this as a regression? After all, the Mu4 result is slightly better in this case.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Jun 7, 2023

For Ped it looks worse, doesn't it? And that's what this issue is about ;-)
It may not a regression, but is inconsistent.

@oktophonie
Copy link
Contributor

oktophonie commented Jul 12, 2023

The task/fix here is to change pedal lines to use the Musical Symbols Font, not the Musical Text Font (just as with ottavas).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engraving P2 Priority: Medium
Projects
5 participants