Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double barline are not joined when imported from XML #20699

Closed
Gai-Luron opened this issue Dec 25, 2023 · 3 comments · Fixed by #22858
Closed

Double barline are not joined when imported from XML #20699

Gai-Luron opened this issue Dec 25, 2023 · 3 comments · Fixed by #22858
Assignees
@oktophonie @miiizen
Labels
MusicXML P2 Priority: Medium regression MS3 Regression from MS3 (3.6.2)

Comments

@Gai-Luron
Copy link

Gai-Luron commented Dec 25, 2023 •
edited
Loading

Issue type

Import/export issue

Bug description

Double barline are not joined when imported from XML

Steps to reproduce

  1. Create a score with multiple part.
  2. Join barline
  3. Export to XML file
  4. Close MuseScore
  5. Reopen MuseScore
  6. Import XML

Double Barline are not join in 4.2.
Same Bug on Master too
Work in MuseScore 3

This is an import issue because same issue occur from file exported with MakeMusic Finale

Screenshots/Screen recordings

This score was exported To XML
image

This score was imported from previous exported file XML
image

Sameissur with end Bar
image

MuseScore Version

MuseScore version (64-bit): 4.2.0-233521124, revision: github-musescore-musescore-eb8d33c

Regression

Choose option...

Operating system

OS: Windows 10 Version 2009 or later, Arch.: x86_64,

Additional context

No response
@oktophonie oktophonie added regression MS3 Regression from MS3 (3.6.2) MusicXML labels Dec 25, 2023
@oktophonie oktophonie self-assigned this Dec 25, 2023
@oktophonie oktophonie added the P2 Priority: Medium label Dec 29, 2023
@rettinghaus
Copy link
Contributor

All barlines except single and repetition barlines are affected.

image

@lvinken
Copy link
Contributor

lvinken commented Feb 6, 2024

Working on it ...

@oktophonie oktophonie assigned lvinken and unassigned miiizen Feb 6, 2024
@lvinken
Copy link
Contributor

lvinken commented Feb 13, 2024

The issue is caused by commit cfbbea8 (iveshenry18 committed on May 28, 2021), ported to 4.2 as commit e6586f6 (mike-spa committed on Nov 16, 2023).

If you want I can provide a fix, but I would like feedback by [mike-spa] first, as I do not know why this change was made and I may have overlooked something.

@oktophonie oktophonie assigned miiizen and unassigned lvinken May 14, 2024
@miiizen miiizen mentioned this issue May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oktophonie oktophonie

@miiizen miiizen

Labels
MusicXML P2 Priority: Medium regression MS3 Regression from MS3 (3.6.2)
Projects
MuseScore Studio 4.4
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix barline spans on xml import miiizen/MuseScore
5 participants
@lvinken @Gai-Luron @rettinghaus @oktophonie @miiizen