Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scores with multibyte characters in the name do not open in a new window (Cyrillic names also) #23811

Closed
4 tasks done
nmu-nyasan opened this issue Jul 29, 2024 · 3 comments · Fixed by #24309
Closed
4 tasks done

Scores with multibyte characters in the name do not open in a new window (Cyrillic names also) #23811

nmu-nyasan opened this issue Jul 29, 2024 · 3 comments · Fixed by #24309
Assignees
@igorkorsukov
Labels
P0 Priority: Critical regression nightly Works correctly in the latest released version and is broken in the nightly builds

Comments

@nmu-nyasan
Copy link

nmu-nyasan commented Jul 29, 2024 •
edited by DmitryArefiev
Loading

Issue type

Opening/saving issue

Description with steps to reproduce

Case 1:

  1. Open MuseScore Studio and open any score.
  2. Return to the “Score” tab with the score still open.
  3. Open a score whose names contain multibyte characters.

Case 2:

  1. (MuseScore Studio is not run)
  2. Open a score whose names contain multibyte characters from Windows Explorer

Supporting files, videos and screenshots

2024-07-29_14-03-14.mp4

What is the latest version of MuseScore Studio where this issue is present?

OS: Windows 11 Version 2009 or later, Arch.: x86_64, MuseScore Studio version (64-bit): 4.4.0-242110305, revision: github-musescore-musescore-bd4bcee

Regression

Yes, this works in the latest released version and is broken in the nightly builds

Operating system

Windows 11 23H2

Additional context

The dialog telling you that the file failed to load shows a garbled string of UTF-8 characters interpreted as Shift_JIS.
image
https://tools.m-bsys.com/dev_tools/char_corruption_for_developer.php
tools m-bsys com_dev_tools_char_corruption_for_developer php

Checklist

  • This report follows the guidelines for reporting bugs and issues
  • I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
  • I have attached all requested files and information to this report
  • I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible
@muse-bot muse-bot added the regression nightly Works correctly in the latest released version and is broken in the nightly builds label Jul 29, 2024
@bkunda bkunda added the P2 Priority: Medium label Jul 30, 2024
@nmu-nyasan
Copy link
Author

This issue also occurs when double-clicking a file from Explorer.
The only way to open a file with multibyte characters in its filename is to start MuseScore Studio with no other scores open and select the score listed on the “Scores” tab.
If the file contains multibyte characters in its filename, there is no way to open a score that is not listed on the “Scores” tab (e.g., an mscz file downloaded from the web), nor can you open more than one file at a time.

@bkunda @cbjeukendrup (sorry for mentioning)
I believe that if version 4.4 is released with this bug still present, it will cause confusion.
Could you please reconsider the priority and fix this before the 4.4 release?

@DmitryArefiev DmitryArefiev changed the title Scores with multibyte characters in the name do not open in a new window. Scores with multibyte characters in the name do not open in a new window (multi-instance mode only) Aug 26, 2024
@DmitryArefiev DmitryArefiev added P1 Priority: High and removed P2 Priority: Medium labels Aug 26, 2024
@DmitryArefiev DmitryArefiev changed the title Scores with multibyte characters in the name do not open in a new window (multi-instance mode only) Scores with multibyte characters in the name do not open in a new window Aug 26, 2024
@DmitryArefiev
Copy link
Contributor

This issue also occurs when double-clicking a file from Explorer.

Yes, I can reproduce it too

bandicam.2024-08-26.17-54-38-315.mp4

@bkunda Since it occurs not only in multi-instance mode I propose to change it to P1

@RomanPudashkin RomanPudashkin mentioned this issue Aug 28, 2024
Closed
4 tasks
@CarlGao4
Copy link

I described the issue more detailed and had guessed the cause of this issue in #24258

@Jojo-Schmitz Jojo-Schmitz mentioned this issue Aug 29, 2024
Closed
4 tasks
@RomanPudashkin RomanPudashkin added P0 Priority: Critical and removed P1 Priority: High labels Aug 29, 2024
@oktophonie oktophonie mentioned this issue Aug 30, 2024
Closed
4 tasks
@DmitryArefiev DmitryArefiev changed the title Scores with multibyte characters in the name do not open in a new window Scores with multibyte characters in the name do not open in a new window (Cyrillic names also) Aug 30, 2024
This was referenced Aug 30, 2024
Merged
Merged
@cbjeukendrup cbjeukendrup mentioned this issue Aug 31, 2024
Closed
4 tasks
@RomanPudashkin RomanPudashkin mentioned this issue Sep 5, 2024
Closed
4 tasks
@Dima-S-Jr Dima-S-Jr mentioned this issue Sep 5, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igorkorsukov igorkorsukov

Labels
P0 Priority: Critical regression nightly Works correctly in the latest released version and is broken in the nightly builds
Projects
MuseScore Studio 4.4.1
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed parse not ascii args igorkorsukov/MuseScore
8 participants
@igorkorsukov @muse-bot @cbjeukendrup @CarlGao4 @RomanPudashkin @bkunda @DmitryArefiev @nmu-nyasan