Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datapath): bring up patch-up port on startup #7659

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

pshelar
Copy link
Contributor

@pshelar pshelar commented Jun 18, 2021

In some cases we have seen patch-up port inconsistencies, it
results in crash loop due to bridge error. Following patch
fixes the issue by manually briging the port down when
bridge is down.

Summary

Test Plan

validated in lab setup.

Additional Information

  • This change is backwards-breaking

@pshelar pshelar requested review from a team and ardzoht June 18, 2021 06:35
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 18, 2021
@pshelar pshelar added apply-v1.5 Apply this commit to the v1.5 release branch as well. apply-v1.6 and removed size/XS Denotes a PR that changes 0-9 lines. labels Jun 18, 2021
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯 Please note that all commits must be signed off. This is enforced by the DCO check.

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@magmabot magmabot added the component: agw Access gateway-related issue label Jun 18, 2021
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #7659 (b13e516) into master (34621ae) will increase coverage by 30.21%.
The diff coverage is n/a.

❗ Current head b13e516 differs from pull request most recent head 1d34688. Consider uploading reports for the commit 1d34688 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7659       +/-   ##
===========================================
+ Coverage   34.23%   64.44%   +30.21%     
===========================================
  Files        1175      680      -495     
  Lines      105584    47045    -58539     
  Branches     1323     1323               
===========================================
- Hits        36144    30317     -5827     
+ Misses      65982    13270    -52712     
  Partials     3458     3458               
Flag Coverage Δ
c_cpp ?
cloud_lint 65.72% <ø> (ø)
feg-lint 56.40% <ø> (-0.02%) ⬇️
lte-test 72.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
feg/gateway/policydb/streamer.go 39.13% <0.00%> (-8.70%) ⬇️
...ateway/c/core/oai/tasks/mme_app/mme_app_location.c
...core/oai/tasks/nas/emm/msg/AuthenticationFailure.c
lte/gateway/c/core/oai/lib/bstr/buniutil.c
...gateway/c/core/oai/tasks/nas/esm/esm_ebr_context.c
lte/gateway/c/core/oai/tasks/nas/ies/PdnAddress.c
...sks/nas5g/src/M5GPDUSessionModificationRequest.cpp
...nas5g/src/ies/M5GExtendedProtocolDiscriminator.cpp
...way/c/core/oai/tasks/gtpv1-u/gtp_tunnel_openflow.c
...ay/c/core/oai/tasks/nas/emm/msg/IdentityResponse.c
... and 486 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34621ae...1d34688. Read the comment docs.

In some cases we have seen patch-up port inconsistencies, it
results in crash loop due to bridge error. Following patch
fixes the issue by manually briging the port down when
bridge is down.

Signed-off-by: Pravin B Shelar <pbshelar@fb.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 18, 2021
@pshelar pshelar merged commit a7c96d8 into magma:master Jun 18, 2021
themarwhal pushed a commit that referenced this pull request Jun 18, 2021
In some cases we have seen patch-up port inconsistencies, it
results in crash loop due to bridge error. Following patch
fixes the issue by manually briging the port down when
bridge is down.

Signed-off-by: Pravin B Shelar <pbshelar@fb.com>
themarwhal pushed a commit that referenced this pull request Jun 18, 2021
In some cases we have seen patch-up port inconsistencies, it
results in crash loop due to bridge error. Following patch
fixes the issue by manually briging the port down when
bridge is down.

Signed-off-by: Pravin B Shelar <pbshelar@fb.com>
rmeleromira pushed a commit to rmeleromira/magma that referenced this pull request Jul 24, 2021
In some cases we have seen patch-up port inconsistencies, it
results in crash loop due to bridge error. Following patch
fixes the issue by manually briging the port down when
bridge is down.

Signed-off-by: Pravin B Shelar <pbshelar@fb.com>
Signed-off-by: Ramon Melero <ramonmelero@fb.com>
m-trojanowski pushed a commit to openEPC/magma that referenced this pull request Oct 20, 2021
In some cases we have seen patch-up port inconsistencies, it
results in crash loop due to bridge error. Following patch
fixes the issue by manually briging the port down when
bridge is down.

Signed-off-by: Pravin B Shelar <pbshelar@fb.com>
m-trojanowski pushed a commit to openEPC/magma that referenced this pull request Oct 20, 2021
In some cases we have seen patch-up port inconsistencies, it
results in crash loop due to bridge error. Following patch
fixes the issue by manually briging the port down when
bridge is down.

Signed-off-by: Pravin B Shelar <pbshelar@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apply-v1.5 Apply this commit to the v1.5 release branch as well. apply-v1.6 backported-v1.5 backported-v1.6 component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants