Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NMS] Fix NMS placeholder for HE #7705

Merged
merged 1 commit into from
Jun 22, 2021
Merged

[NMS] Fix NMS placeholder for HE #7705

merged 1 commit into from
Jun 22, 2021

Conversation

karthiksubraveti
Copy link
Contributor

Signed-off-by: Karthik Subraveti ksubraveti@fb.com

Summary

Test Plan

Additional Information

  • This change is backwards-breaking

@karthiksubraveti
Fix NMS placeholder for HE
2a376b2 
Signed-off-by: Karthik Subraveti <ksubraveti@fb.com>
@karthiksubraveti karthiksubraveti requested review from a team and andreilee June 22, 2021 16:32
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 22, 2021
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯 Please note that all commits must be signed off. This is enforced by the DCO check.

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@sudhikan
Copy link
Contributor

cc: @pshelar

@karthiksubraveti karthiksubraveti added apply-v1.5 Apply this commit to the v1.5 release branch as well. apply-v1.6 labels Jun 22, 2021
@karthiksubraveti karthiksubraveti enabled auto-merge (squash) June 22, 2021 16:35
pshelar
pshelar approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@pshelar pshelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@karthiksubraveti karthiksubraveti merged commit 70f14bb into magma:master Jun 22, 2021
themarwhal pushed a commit that referenced this pull request Jun 22, 2021
@karthiksubraveti @themarwhal
Fix NMS placeholder for HE (#7705)
562baa6 
Signed-off-by: Karthik Subraveti <ksubraveti@fb.com>
themarwhal pushed a commit that referenced this pull request Jun 22, 2021
@karthiksubraveti @themarwhal
Fix NMS placeholder for HE (#7705)
1d4e976 
Signed-off-by: Karthik Subraveti <ksubraveti@fb.com>
rmeleromira pushed a commit to rmeleromira/magma that referenced this pull request Jul 24, 2021
@karthiksubraveti @rmeleromira
Fix NMS placeholder for HE (magma#7705)
067cb8b 
Signed-off-by: Karthik Subraveti <ksubraveti@fb.com>
Signed-off-by: Ramon Melero <ramonmelero@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HannaFar HannaFar HannaFar approved these changes

@pshelar pshelar pshelar approved these changes

@andreilee andreilee Awaiting requested review from andreilee

Assignees
No one assigned
Labels
apply-v1.5 Apply this commit to the v1.5 release branch as well. apply-v1.6 backported-v1.5 backported-v1.6 size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@karthiksubraveti @sudhikan @pshelar @HannaFar @themarwhal