Fixes #199 #200
Fixes #199 #200
Conversation
|
This is impressive. I'll review! |
| var serve = buildServe(iface, mosca); | ||
| var server = http.createServer(serve); | ||
|
|
||
| mosca.attachHttpServer(server); // REFACTOR? |
There was a problem hiding this comment.
This is currently offered as a public API. If we want to refactor it, we need to do it providing backward compatibility.
Ideally that belongs on its own file.
There was a problem hiding this comment.
I meant that this line does not actually belong here, but I was not able to find a better place for it.
There was a problem hiding this comment.
well, it does (kind of). You are creating the http server, and you need to add hooks for websockets.
|
Really well written, thanks. Just one question: should we change the default API? the I would like to have the same style of refactoring for persistence and backend, most of the times you just use Redis or Mongo for both. Does it make sense? |
|
To be honest I have no problem with Regarding backend and persistence. I'm currently using default option for both, so my opinion on this is kinda worthless. But I think it makes sense to use a single tech for both backend and persistence. Maybe there's even no point in separation between them. |
|
Anyway, I'm going to merge this and get it released next week. Would you like to help in fixing the wiki? |
|
I've just released 0.26.0 with this fix in! Can you help me updating the docs? |
Fixes #199
Summary:
interfacesis not present in options, it's constructed from legacy keys, otherwise left as iscredentialsis not present in options, it's constructed fromsecure, otherwise left as is