Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always allow localhost:* in embedding-app-origin #47615

Closed
WiNloSt opened this issue Sep 4, 2024 · 0 comments · Fixed by #47663
Closed

Always allow localhost:* in embedding-app-origin #47615

WiNloSt opened this issue Sep 4, 2024 · 0 comments · Fixed by #47663
Assignees
@WiNloSt
Labels
Embedding/SDK Embedding SDK for React .Team/Embedding
Milestone
0.50.25

Comments

@WiNloSt
Copy link
Member

WiNloSt commented Sep 4, 2024

Note

The work in the PR should be replaced by the work in #46970 when merged.

This is a follow up task for #47229. As a temporary measure as the actual work would be implemented in #46970, but that feature won't be merged to master until we feel ready.

Without this, we won't be able to test the CLI without valid enterprise token, because without valid tokens, users can't modify embedding-app-origin.
@WiNloSt WiNloSt added .Task Not a part of any Epic, used by the Task Issue Template and removed .Task Not a part of any Epic, used by the Task Issue Template labels Sep 4, 2024
@WiNloSt WiNloSt self-assigned this Sep 4, 2024
@WiNloSt WiNloSt added .Team/Embedding Embedding/SDK Embedding SDK for React labels Sep 4, 2024
@WiNloSt WiNloSt mentioned this issue Sep 5, 2024
Merged
1 task
@github-actions github-actions bot added this to the 0.50.25 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WiNloSt WiNloSt

Labels
Embedding/SDK Embedding SDK for React .Team/Embedding
Projects
None yet
Milestone
0.50.25
Development

Successfully merging a pull request may close this issue.

Always allow localhost:* on CORS metabase/metabase
1 participant
@WiNloSt