Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy evaluation of voidElements #187

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

johnsoncodehk
Copy link
Contributor

@johnsoncodehk johnsoncodehk commented Apr 24, 2024

Resolves vuejs/language-tools#4298

provideTags can be expensive and should be called on demand whenever possible to avoid unnecessary calculations.

@johnsoncodehk
Copy link
Contributor Author

Hi @aeschli, sorry for the ping, any chance we have a look at this PR?

@VSCodeTriageBot VSCodeTriageBot added this to the May 2024 milestone Jun 5, 2024
@aeschli aeschli merged commit 907177e into microsoft:main Jun 24, 2024
2 checks passed
@aeschli aeschli modified the milestones: May 2024, June 2024 Jun 24, 2024
@johnsoncodehk johnsoncodehk deleted the lazy-get-void-elements branch June 24, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Significant performance impact in VSCode
4 participants