-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to see comments in commits file view #2688
Comments
Comments that were made when your PR was on the commit that you have selected should now show. |
I'm seeing a couple of issues, not sure if they're related to this. When trying to check out the PR from the overview page, I get a "branch not found" error. Then when I manually change to the branch and attempt to open the commit file, I get a "couldn't find commit" GHPR: v2021.6.42304 While on Windows I don't see these issues but then the original issue still repros. |
Opened a new issue for the checkout from overview issue: #2812 @misolori I'm able to see comments in files opened from the commits tree. Note that each comment will only show on one of the commits. Comments are mapped to commits, so each comment will only show in the commit for which that comment was added. (the commit hash isn't shown in the tree right now, I will add that in the hover for July since it seems useful). Can you double check that you had the commit that the comment was associated with open? |
I'm still seeing this, here's another PR example: Opening fileOpening the commit❌ This does not show any commits even though there is 💬 icon on the file |
I guess the question really is: should i be able to see comments from the commits node in addition to the files node? If not then we should hide the 💬 icon from that item in that node as it's confusing. |
I'll mark this issue as verification found again based on Miguel's question above. |
I can repro with the PR that Miguel was testing with. |
The issue is that the comments associated with the most recent commit will not show in that commit. Fix doesn't look low risk, so moving to July. |
Refs microsoft/vscode#122245
I'm unsure if this is expected or not, but I at least expected to see the same comments from the Files section appear under the file in the Commits section as well
Files
Commits
GH PR Version: v2021.4.39423
Version: 1.56.0-insider (user setup)
Commit: 13f1afffab09548c10ddb3bc5d5db52587876ad8
Date: 2021-04-28T04:52:06.990Z
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: 8.9.255.24-electron.0
OS: Windows_NT x64 10.0.19042
The text was updated successfully, but these errors were encountered: