-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placeholder title when creating a PR does not behave like GitHub website #2988
Comments
I've been seeing this recently and I suspect it's due to #2846 (since that was the only change in the right timeframe). @joshuaobrien any thoughts on what might have happened? |
Thanks for the tag. I'll take a look @mtaran |
I'm not seeing this now. @mcaballeropinto does your repo have a PR template? |
Nop, it does not. This is issue is actually intermittent, I sometimes get the right title but others I get the branch name. I can't figure out how to repro it consistently. |
Closing for now. If I see it again I'll re-open. |
I'm seeing this now as well. (Spent awhile looking for the setting to fix before realizing the settings were removed) I'm not sure which info is needed though. I first reproduced it with an unpublished branch but can also reproduce it with a random branch like: https://github.com/melink14/rikaikun/tree/melink14/xo (Creating pull request in Github UI behaves as expected with title == commit) |
Reopening for further investigation. |
As a follow up, I realized that melink14/xo branch has two commits so it's not the best example. Though the behavior still differs from the Github default of using the first commit. I went ahead and published the branch I first noticed this on (without opening a PR) for easier testing: In this one as well, Create Pull Request in vscode gives |
+1! I also still hit this pretty regularly. I only noticed that it's not especially consistent, but happens less on already-uploaded branches. Would love to see this fixed, since it's a key part of one of the most common and high-impact uses of this extension. |
One way I've been able to reproduce: when creating a PR that targets a non-default branch, after switching to it the title and description should be updated, iff the new branch has a single commit only compared to the new "into" branch. This is something that happens quite often when developing against an "unstable" branch, while the "stable" branch is set as the default. Github automatically detects when switching into branches and fills in the title / description. |
Verfied but opened #3357 as a result of testing this |
Commenting here to preserve past context but let me know if opening a new issue would be preferred. I'm still seeing this for about 50% of new PRs I create but I'm not sure exactly what could be causing it. This branch was ontop of main with only one commit made via the vs code source control UI. The output doesn't appear to have anything logged when creating a pull request; is there someway to turn on verbose logging and get output containing the reasons why it chose fallback PR title? |
@melink14 I just pushed some additional logging around how we get the title. It will be available in the preview version of the extension tomorrow. If you want to help track this down, you can install the preview version tomorrow and use the setting |
Thanks alex, I switched to preview version and will set log level in preparation for helping debug! |
Issue Type: Bug
Repro steps:
Expected:
Actual:
Extension version: 2021.9.1985
VS Code version: Code 1.60.0 (Universal) (e7d7e9a9348e6a8cc8c03f877d39cb72e5dfb1ff, 2021-09-01T10:54:53.442Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No
System Info
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
A/B Experiments
The text was updated successfully, but these errors were encountered: