Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No way to remove Milestone #5102

Closed
hbons opened this issue Jul 25, 2023 · 2 comments · Fixed by #5171
Closed

No way to remove Milestone #5102

hbons opened this issue Jul 25, 2023 · 2 comments · Fixed by #5171
Assignees
@alexr00
Labels
feature-request Request for new features or functionality ux verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2023

Comments

@hbons
Copy link
Member

hbons commented Jul 25, 2023 •
edited
Loading

Forgot to add a way to remove a milestone. :)

We could add an item to the quick pick: "Clear Milestone" followed by a separator when a milestone is already set.
Also, we don't currently focus the picked Milestone.
@hbons hbons added feature-request Request for new features or functionality ux labels Jul 25, 2023
@alexr00 alexr00 self-assigned this Jul 25, 2023
@alexr00 alexr00 added this to the August 2023 milestone Jul 25, 2023
@hbons hbons mentioned this issue Jul 26, 2023
Closed
@alexr00 alexr00 mentioned this issue Aug 11, 2023
Merged
alexr00 added a commit that referenced this issue Aug 11, 2023
@alexr00
No way to remove Milestone
e72de6e 
Fixes #5102
alexr00 added a commit that referenced this issue Aug 11, 2023
@alexr00
No way to remove Milestone (#5171)
2bbf180 
Fixes #5102
@alexr00 alexr00 added the verification-needed Verification of issue is requested label Aug 28, 2023
@alexr00
Copy link
Member

alexr00 commented Aug 28, 2023

To verify:

  • Install the pre-release version of the extension
  • Open a folder that contains a GitHub repo
  • Run the "Create Pull Request" command (you won't actually need to create a PR, just run the command).
  • Add a milestone to the PR that you're creating
  • Verify that you can remove the milestone.

@hbons
Copy link
Member Author

hbons commented Aug 29, 2023

Verified I can remove the milestone after adding.

@alexr00 alexr00 added the verified Verification succeeded label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
feature-request Request for new features or functionality ux verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2023
Development

Successfully merging a pull request may close this issue.

No way to remove Milestone microsoft/vscode-pull-request-github
2 participants
@hbons @alexr00