Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to view changed files in a tree instead of a list #653

Closed
devhawk opened this issue Oct 31, 2018 · 6 comments
Closed

Option to view changed files in a tree instead of a list #653

devhawk opened this issue Oct 31, 2018 · 6 comments
Labels
feature-request Request for new features or functionality

Comments

@devhawk
Copy link

devhawk commented Oct 31, 2018

Currently, the list of changed files appears as a flat list. Can it be in a hierarchy according to repo folder?

Current experience:

capture1

Requested experience (screen shot from Tree Explorer for GitHub Chrome Extension

capture2

@rebornix rebornix added the feature-request Request for new features or functionality label Oct 31, 2018
@rebornix
Copy link
Member

rebornix commented Oct 31, 2018

Good idea! We can probably have several different ways to display the file changes

  1. flat list
- src/extension.ts
- src/view/tree/prNode.ts
  1. tree
- src
  - extension.ts
  - view 
    - tree
      - prNode.ts
  1. tree but skipping single node folders
- src
  - extension.ts
  - view/tree/
    - prNode.ts

cc @misolori

@jerrymajewski
Copy link
Contributor

I submitted a PR that demonstrates Option 3: #655.

@miguelsolorio
Copy link
Contributor

I like the idea. If we're going to add this, we should definitely provide an option/setting to allow the user to change it based upon their preferences.

@borekb
Copy link

borekb commented May 27, 2019

Git Tree Compare does this nicely, e.g.:

Screenshot 2019-05-27 at 10 38 44

@Israel-Kli
Copy link

Israel-Kli commented Jun 2, 2019

Git Tree Compare does this nicely, e.g.:

GitLens knows to do it even cooler (in addition to various other things):

2019-06-02 16_26_13-get js (master) ⟷ get js (bug_596-Hidden-Tags-are-lost-when-saving-product-in-MP

@yulrizka
Copy link
Contributor

yulrizka commented Oct 5, 2019

@rebornix, any reason this is not being picked up? This is super useful, especially when looking at big changes.

I also tried 3 different view implementation. I think the compact-tree gives the most clarity, especially with deep tree.

comparison-file-changed-view

  1. flat-tree, I adapt Display the PR changed files in a tree, closes #653. #655
  2. full-tree. gives the whole folder tree
  3. compact-tree. optimization of no. 2 with directory having only single directory merged Compact tree to display changed files #1358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

8 participants
@devhawk @borekb @yulrizka @rebornix @Israel-Kli @jerrymajewski @miguelsolorio and others