Updates TypeScript (released 4.2) and Octokit (to get fixed types), and a couple minor others #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMacfarlane
reviewed
Feb 25, 2021
package.json
Outdated
| @@ -1408,13 +1408,13 @@ | |||
| "@types/react-dom": "^16.8.2", | |||
| "@types/sinon": "7.0.11", | |||
| "@types/temp": "0.8.34", | |||
| "@typescript-eslint/eslint-plugin": "4.15.1", | |||
| "@typescript-eslint/parser": "4.15.1", | |||
| "@typescript-eslint/eslint-plugin": "4.15.2", | |||
There was a problem hiding this comment.
Should we apply ^ everywhere?
Removes any because of updated typings
dade2f8
to
dcecda2
Compare
alexr00
approved these changes
Dec 19, 2022
aeschli
approved these changes
Dec 19, 2022
eslamashour1
pushed a commit
to eslamashour1/vscode-pull-request-github
that referenced
this pull request
Dec 31, 2022
…nd a couple minor others (microsoft#2525)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes an
as anybecause of the fixed octokit typings