Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect remote link type for upstream #2929

Merged
merged 5 commits into from
Sep 1, 2021
Merged

Respect remote link type for upstream #2929

merged 5 commits into from
Sep 1, 2021

Conversation

burkeholland
Copy link
Collaborator

Fixes #2740

Respect the protocol of existing remotes. Right now, just looking at the first remote so whatever the first one is, so will the upstream be.

@alexr00 alexr00 added this to the August 2021 milestone Aug 23, 2021
src/github/folderRepositoryManager.ts Outdated Show resolved Hide resolved
@alexr00 alexr00 self-assigned this Aug 24, 2021
@alexr00 alexr00 modified the milestones: August 2021, September 2021 Aug 24, 2021
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will merge after the August release!

@alexr00 alexr00 merged commit be55caa into microsoft:main Sep 1, 2021
@alexr00 alexr00 changed the title burkeholland-issue2740 Respect remote link type for upstream Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension does not respect remote link type for upstream
2 participants