Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change file mode for execute husky hook on MacOS #4695

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Change file mode for execute husky hook on MacOS #4695

merged 1 commit into from
Apr 14, 2023

Conversation

Balastrong
Copy link
Contributor

This issue fixes #4662

I'm on MacOS Ventura 13.2.1 and the husky hook is not executed, probably due to a wrong file mode.

$ ls -l .husky/pre-commit
-rw-r--r--  1 leonardo  staff  69 Mar 31 18:53 .husky/pre-commit
$ chmod ug+x .husky/*                         
$ ls -l .husky/pre-commit
-rwxr-xr--  1 leonardo  staff  69 Mar 31 18:53 .husky/pre-commit

Now that I have added the x permission I see the hook is properly executed.

@alexr00 alexr00 added this to the April 2023 milestone Apr 11, 2023
@alexr00 alexr00 enabled auto-merge (squash) April 14, 2023 14:00
@alexr00
Copy link
Member

alexr00 commented Apr 14, 2023

Thanks for the PR!

@alexr00 alexr00 merged commit b2e86df into microsoft:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrieken jrieken jrieken approved these changes

@alexr00 alexr00 alexr00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
April 2023
Development

Successfully merging this pull request may close these issues.

Husky hooks are not executed
3 participants
@Balastrong @alexr00 @jrieken