Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added instructions for windows users #108

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Conversation

fallanic
Copy link
Contributor

This is a fix for #107

The current jest configuration doesn't actually work on windows (it's a weird VS code launch problem, running ./node_modules/.bin/jest in a powershell in VS code does work).

So I

  • added a workaround configuration for windows users
  • added a comment for windows users using jest-cli instead of jest so they know how to edit the config to make it work

@msftclas
Copy link

msftclas commented Jun 22, 2018

CLA assistant check
All CLA requirements met.

@fallanic
Copy link
Contributor Author

ping @auchenberg whenever you have a chance 🙂

@auchenberg
Copy link
Contributor

LGTM

@auchenberg auchenberg merged commit 62e6544 into microsoft:master Jun 26, 2018
@auchenberg auchenberg added this to the July 2018 milestone Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants