Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request for Jest issue - SecurityError: localStorage is not available for opaque origins #119 #120

Merged

Conversation

NileshParkhe83
Copy link
Contributor

Pull request for Jest error - SecurityError: localStorage is not available for opaque origins #119

Jsdom just recently upgraded to version 11.12, which includes support for window.localStorage and other features. See https://github.com/jsdom/jsdom/blob/master/Changelog.md.

Jest does not raise above error when Node is specified as the test environment.

Pull request raised to add above change to documentation if appropriate.

Please excuse any inconvenience I may cause. This is my first pull request on a public github repository.

Thanks.

Pull request for Issue reported below:
Jest error - SecurityError: localStorage is not available for opaque origins microsoft#119
Pull request for Jest error - SecurityError: localStorage is not available for opaque origins microsoft#119

Please excuse any inconvenience I may have caused as I this is only my first commit on github public repository.
@msftclas
Copy link

msftclas commented Jul 30, 2018

CLA assistant check
All CLA requirements met.

@auchenberg
Copy link
Contributor

Thanks @NileshParkhe83 this looks good!

@auchenberg auchenberg merged commit 0d85153 into microsoft:master Jul 30, 2018
@NileshParkhe83 NileshParkhe83 deleted the JSDOM-security-error-patch-1 branch July 30, 2018 16:57
@auchenberg auchenberg added this to the July 2018 milestone Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants