Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aux window: open issue reporter on current screen #224137

Closed
justschen opened this issue Jul 29, 2024 · 2 comments · Fixed by #224440
Closed

Aux window: open issue reporter on current screen #224137

justschen opened this issue Jul 29, 2024 · 2 comments · Fixed by #224440
Assignees
@justschen
Labels
insiders-released Patch has been released in VS Code Insiders issue-reporter Issue reporter widget issues verification-needed Verification of issue is requested verified Verification succeeded workbench-auxwindow Issues related to use of auxiliary ("floating") windows.
Milestone
August 2024

Comments

@justschen
Copy link
Contributor

atm, when you open a new aux window when your main vs code window is in another secondary screen/monitor, it will open the aux window the main screen/monitor.

  • in these two examples, i have one large curved secondary monitor where vs code is.
  • open an aux window, and it spawns it in my laptop's screen.
  • same thing if full screened on secondary monitor. different when full screen on main screen (see Aux window: prevent fullscreen for issue reporter #224136)
for.issue.reporter.using.aux.mov
for.move.to.new.window.mov

wondering if there is a way it can spawn on the current screen? ie, centered to where the vs code window is.
@justschen justschen added the workbench-auxwindow Issues related to use of auxiliary ("floating") windows. label Jul 29, 2024
@bpasero bpasero changed the title aux window does not open on current screen Aux window: open issue reporter on current screen Jul 29, 2024
@bpasero
Copy link
Member

bpasero commented Jul 29, 2024

@justschen that should be possible if you provide the coordinates for where to open the window via IAuxiliaryWindowOpenOptions:

vscode/src/vs/workbench/services/auxiliaryWindow/browser/auxiliaryWindowService.ts

Line 244 in d12c0c7

async open(options?: IAuxiliaryWindowOpenOptions): Promise<IAuxiliaryWindow> {

You would have to calculate the right coordinates based on all opened monitors, which is a bit tricky and probably requires you to go to the main process to do the math. This could be exposed from the nativeHostMainService.

Alternatively, another custom vscode feature flag that allows you to pass in the identifier of a window to center the issue reporter over.

@bpasero bpasero added the issue-reporter Issue reporter widget issues label Jul 29, 2024
@justschen justschen mentioned this issue Jul 31, 2024
Merged
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Aug 1, 2024
@vs-code-engineering vs-code-engineering bot added this to the July 2024 milestone Aug 1, 2024
@bpasero bpasero modified the milestones: July 2024, August 2024 Aug 1, 2024
@bpasero bpasero added the verification-needed Verification of issue is requested label Aug 1, 2024
@bpasero bpasero removed their assignment Aug 1, 2024
@vs-code-engineering vs-code-engineering bot removed the unreleased Patch has not yet been released in VS Code Insiders label Aug 2, 2024
@vs-code-engineering VS Code Engineering
Copy link 

		Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting `\closedWith someCommitSha`, or directly add the `insiders-released` label if you know this has already been releaased

@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Aug 2, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 24, 2024
@anthonykim1 anthonykim1 added the verified Verification succeeded label Aug 28, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@justschen justschen

Labels
insiders-released Patch has been released in VS Code Insiders issue-reporter Issue reporter widget issues verification-needed Verification of issue is requested verified Verification succeeded workbench-auxwindow Issues related to use of auxiliary ("floating") windows.
Projects
None yet
Milestone
August 2024
Development

Successfully merging a pull request may close this issue.

center aux window on current screen justschen/vscode
3 participants
@bpasero @justschen @anthonykim1