Close param hints if you reach out of bounds of list instead of cycling #53757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
reviewed
Jul 9, 2018
|
|
||
| if (length < 2) { | ||
| // If there is only one signature, or we're on last signature of list | ||
| if (length < 2 || last) { |
There was a problem hiding this comment.
You might as well update the lower bits in these functions because now you won't ever reach them with the spill over/under.
There was a problem hiding this comment.
Good point! Will update.
There was a problem hiding this comment.
@jrieken okay - how's that?
|
lgtm. thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution to the issue of not being able to escape the param hints with only arrows:
Here's the issue