Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trimmed file search strings in the search menu #54625

Merged
merged 2 commits into from
Jul 19, 2018
Merged

Trimmed file search strings in the search menu #54625

merged 2 commits into from
Jul 19, 2018

Conversation

JoshuaKGoldberg
Copy link
Contributor

As suggested by roblourens, goes through queryBuilder's query to trim the filePattern.

Fixes #54529.

Josh Goldberg added 2 commits July 18, 2018 19:42
Trimmed file search strings in the search menu
0ed4d0e 
As suggested by roblourens, goes through `queryBuilder`'s `query` to trim the `filePattern`.

Fixes #54529.
Allowed undefined options.filePattern
d7ea94d 
Forgot you folks aren't on strict types!
roblourens
roblourens approved these changes Jul 19, 2018
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roblourens roblourens added this to the July 2018 milestone Jul 19, 2018
@roblourens roblourens merged commit fb20a9b into microsoft:master Jul 19, 2018
@JoshuaKGoldberg JoshuaKGoldberg deleted the file-search-trim branch July 19, 2018 16:09
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@roblourens roblourens

Labels
None yet
Projects
None yet
Milestone
July 2018
Development

Successfully merging this pull request may close these issues.

Trim the file name in the search menu
2 participants
@JoshuaKGoldberg @roblourens