-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect terminal links with space, then line:col #153957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I added a test to make sure we don't break it 🙂
Thanks for adding the test, @Tyriar. |
This commit seems to break links of the form: |
@galenbwill you might be seeing #155065 which isn't out in insiders yet? |
For path like './web/pages/home/componentPanel.tsx:55:9' @Tyriar still an issue in latest insider.
|
@tjx666 both |
I can confirm that
|
This PR fixes #140780
To test, you can open a terminal and run
echo ./myFile.txt 10:5
(replacing the filename with one that exists). When you click to open the file, it should open to line 10, column 5.