Write selection text to hidden textarea on macOS #156717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85af984
to
7a50a74
Compare
hediet
previously approved these changes
Aug 2, 2022
bpasero
requested changes
Sep 6, 2022
bpasero
approved these changes
Sep 9, 2022
hediet
approved these changes
Sep 9, 2022
|
I have read comments, but I am too busy to pick this up. Thank you for the improvement! Couldn't agree more! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27799
Explanation
macOS services will use
textareacontent and selection as an input source.this hidden
textareais originally for screen readers or accessibility devices. However, the textarea could be empty when user selecting text on macOS.read more details in
macOS: OS services cannot pick up selected text from editor #27799 (comment)
Before
macOS services are not available when
editor.accessibilitySupportsetting isofforautoAfter (hidden textarea is made visible for illustration)
Code-OSS-30Jul22_23-10-19.mp4