Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

composition enter should not accept rename #174829

Merged
merged 1 commit into from
Mar 16, 2023
Merged

composition enter should not accept rename #174829

merged 1 commit into from
Mar 16, 2023

Conversation

lawvs
Copy link
Contributor

@lawvs lawvs commented Feb 20, 2023 •
edited
Loading

Fix the issue where pressing enter while using CJK input method triggers unexpected confirmation of rename operation, which may also result in malfunctioning of rename operation.

Screen.Recording.2023-02-20.at.7.14.17.PM.mov

@lawvs lawvs force-pushed the fix/rename-composing branch 3 times, most recently from 7da38e4 to 3c07818 Compare March 2, 2023 15:55
@lszomoru lszomoru assigned jrieken and unassigned lszomoru Mar 9, 2023
@jrieken jrieken added this to the March 2023 milestone Mar 16, 2023
jrieken
jrieken approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is a great fix

@hediet hediet merged commit 628f427 into microsoft:main Mar 16, 2023
@lawvs lawvs deleted the fix/rename-composing branch March 16, 2023 15:28
uzkjzjjz
uzkjzjjz reviewed Apr 21, 2023
View reviewed changes
Copy link

@uzkjzjjz uzkjzjjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent edition

@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uzkjzjjz uzkjzjjz uzkjzjjz left review comments

@jrieken jrieken jrieken approved these changes

@bpasero bpasero bpasero approved these changes

Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
March 2023
Development

Successfully merging this pull request may close these issues.
6 participants
@lawvs @bpasero @jrieken @uzkjzjjz @hediet @lszomoru