Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add confirmation before removing cell for #173481 #179776

Merged
merged 5 commits into from
Apr 17, 2023
Merged

add confirmation before removing cell for #173481 #179776

merged 5 commits into from
Apr 17, 2023

Conversation

weartist
Copy link
Contributor

@weartist weartist commented Apr 12, 2023 •
edited by roblourens
Loading

Fixes #173481

@rebornix rebornix assigned roblourens and unassigned hediet Apr 12, 2023
roblourens
roblourens reviewed Apr 12, 2023
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/vs/workbench/contrib/notebook/browser/controller/editActions.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/notebook/browser/controller/editActions.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/notebook/browser/controller/editActions.ts Outdated Show resolved Hide resolved
@weartist
💄
8788e8a
@weartist
optimize the dialog message
304c217
@weartist
remove unnecessary detail
210bcb4
@weartist
Merge remote-tracking branch 'upstream/main' into support_confirm_del…
48801fb 
…ete_running_cell

# Conflicts:
#	src/vs/workbench/contrib/notebook/browser/notebook.contribution.ts
@roblourens roblourens added this to the April 2023 milestone Apr 17, 2023
@roblourens roblourens merged commit 8ff4e20 into microsoft:main Apr 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees

@roblourens roblourens

Labels
None yet
Projects
None yet
Milestone
April 2023
Development

Successfully merging this pull request may close these issues.

Deleting cell should have confirmation before removing cell
5 participants
@weartist @roblourens @DonJayamanne @hediet @VSCodeTriageBot