Fix collapseAll command when no folder is open
#180330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lramos15
reviewed
Apr 19, 2023
| const explorerView = viewsService.getViewWithId(VIEW_ID) as ExplorerView; | ||
| explorerView.collapseAll(); | ||
| const view = viewsService.getViewWithId(VIEW_ID); | ||
| if (view !== null) { |
There was a problem hiding this comment.
Do we want if (view) to cover null and undefined?
There was a problem hiding this comment.
since the type of view is IView | null I didn't think so
There was a problem hiding this comment.
(normally I would do that but because big codebase I wanted it to be an explicit check to avoid confusion)
alexr00
approved these changes
Apr 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a null check before casting a view to
ExplorerViewand runningcollapseAll, to avoid a potentialTypeErrorwhen the view is null.Changes Made
I added a check for null before casting to
ExplorerViewand runningcollapseAll, as shown in this code snippet:Testing Done
I tested this change in Code OSS dev, both with and without the changed code, to verify that the view is properly collapsed when it is not null.
Screenshots
Error Message Before Fix
Fix in Action
no error message