Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment typo in standaloneLanguages.ts #189449

Merged
merged 4 commits into from
Aug 25, 2023

Conversation

hrkw00
Copy link
Contributor

@hrkw00 hrkw00 commented Aug 2, 2023

I just fixed comment typo in src/vs/monaco.d.ts.

Actually , the file is generated automatically. Instead of that, fix a comment in src/vs/editor/standalone/browser/standaloneLanguages.ts

I know it's not a big deal, so close it if it's annoying.

@hrkw00 hrkw00 marked this pull request as draft August 2, 2023 06:52
@@ -6241,7 +6241,7 @@ declare namespace monaco.languages {

/**
* An event emitted when a language is associated for the first time with a text model or
* whena language is encountered during the tokenization of another language.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is automatically generated. Instead try finding the original comment in a normal .ts file and fix it there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mjbvz !

I found the original file, and fix it in ddc357c.

Could you check it again please?

This reverts commit 75c1173.
@hrkw00 hrkw00 changed the title Fix comment typo in type definition file Fix comment typo in standaloneLanguages.ts Aug 3, 2023
mjbvz
mjbvz previously approved these changes Aug 9, 2023
@mjbvz
Copy link
Collaborator

mjbvz commented Aug 9, 2023

Thanks but you also need to run the build which will update monaco.d.ts based on the changed file

@mjbvz mjbvz added this to the August 2023 milestone Aug 9, 2023
@hrkw00
Copy link
Contributor Author

hrkw00 commented Aug 10, 2023

@microsoft-github-policy-service agree

@hrkw00
Copy link
Contributor Author

hrkw00 commented Aug 10, 2023

@mjbvz I ran gulp watch and generate a new 'monaco.d.ts` e892351

Is it ok?

@mjbvz mjbvz marked this pull request as ready for review August 16, 2023 22:29
@mjbvz mjbvz merged commit ca462c0 into microsoft:main Aug 25, 2023
6 checks passed
@hrkw00 hrkw00 deleted the hrkw00/fix-typo-2023-08-02 branch August 26, 2023 09:20
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants