Append the focused view in the window title #190216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalmar1332
approved these changes
Aug 11, 2023
|
@ChaseKnowlden thanks for working on this! we'll want to include this as an option in the settings - not as something that's always included |
|
thanks for adding the setting. looks like a test failure now @ChaseKnowlden |
meganrogge
reviewed
Aug 15, 2023
|
there's some recursion going on atm @ChaseKnowlden and even when I fix that, it's not working bc cc @sandy081 for feedback here on a different approach |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #97790
The view is appended into the windows title.