Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev container node version #190346

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

Timmmm
Copy link
Contributor

@Timmmm Timmmm commented Aug 13, 2023

VSCode requires version Node version 18-20, however 20 doesn't work because it is incompatible with eslint-plugin-jsdoc@39.3.2.

Fixes #190331

VSCode requires version Node version 18-20, however 20 doesn't work because it is incompatible with `eslint-plugin-jsdoc@39.3.2`.

Fixes microsoft#190331
Copy link
Contributor

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We still need #189882 for the yarn install step to succeed.

@deepak1556 deepak1556 added this to the August 2023 milestone Aug 14, 2023
@deepak1556 deepak1556 merged commit b7ebbb6 into microsoft:main Aug 14, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Node version in dev container
4 participants