Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dispose template data disposables in source column renderer #202618

Merged
merged 1 commit into from
May 28, 2024

Conversation

SimonSiefke
Copy link
Contributor

Fixes #202455

For testing:

  1. Open the keybindings editor
  2. Close the keybindings editor
  3. Repeat a opening and closing the keybindings editor a few times
  4. The total event listener count should increment at the start, but then should stop incrementing (on my computer it grows from 968 to 1740 but stops at 1740 event listeners)

Test output

{
  "eventListenerCount": {
    "before": 1740,
    "after": 1740
  },
  "isLeak": false
}

@ulugbekna ulugbekna added this to the May 2024 milestone Apr 24, 2024
@ulugbekna ulugbekna enabled auto-merge (squash) May 28, 2024 11:48
@ulugbekna ulugbekna merged commit 38b63e5 into microsoft:main May 28, 2024
6 checks passed
@microsoft microsoft locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak in keybindings editor
3 participants