@microsoft-github-policy-service agree

@Maximetinu thanks for this. we cannot use externally provided sounds. We have a sound designer, @AFre100, that we use for such things.

Why was this closed, can't the sound just be replaced? This is the second PR opened for this (the first being #204408) and the work is essentially done but it's not's not clear what the next step is for this. Will a sound be created by the Code team?

(FWIW, I think the sound in the video above really complements the existing failure sound 🙂)

@meganrogge let's use this PR as a base regardless of whether we use the new sound of not. I'm not sure if there are rules around accepting external sounds but we can verify that, if we can accept it and plan on replacing it then we could merge this and mark it as experimental and then swap out the sound when it's ready.

@Tyriar @meganrogge It's very cool that someone made a sound externally! I see the logic of its design :)

Unfortunately (booo), no matter how great it might be, rule of thumb is to never ship external sound assets in this manner due to multiple risks (legal, IP, copyright, accessibility, UX, brand, etc).

Re marking this experimental -- this means including it in Insiders, right? It'd be beneficial to provide temporary placeholder sound(s), so long as it's ok to replace w/a different final sound in the future.

If possible, we always avoid confusing users if there's a chance they'll get used to sound 1, only to have it changed to sound 2. This is particularly sensitive for audio assets, and has caused issues in the past. I'm pretty sure (?) it happened due to use in a stable build, not a short lived Insiders or testing situation -- happy to zero in on the parameters with you all more.

(Btw, very happy to discuss any of this on a call if useful!). Couple things:

• If we definitely would like a "success" sound, can you give me a date you'd like this for, and we can definitely roadmap?

• And if there's a situation where we need placeholder sounds (and it isn't risky), when would you need that by?

@AFre100
If you want to use the sound for now as placeholder it isn't a problem for me. The sound itself was made from the project 'warning' sound, so it won't cause any kind of legal, IP or copyright issues.

Thank you for the kind words about it, we really thinked about how to make a well implemented sound for vscode (firstly I tried to make some from scratch).

Have a nice week you all! :)

@JuanjeMC Appreciate that info and figured as such -- awesome design thinking and execution, no doubt. Unfortunately, as absurd as it sounds, that mitigates only a fraction of the many existing legal and copyright liabilities for a situation like this.

Extremely punk rock and open source vibes, I know.

Thanks again for doing a cool thing, and we will definitely consider that design concept. (It's also cool to see it mocked up because, crucially, it demonstrates the likelihood of rapid repetition.)

cc @meganrogge @Tyriar sent you all and email about this :)

@meganrogge et all, I'm thinking that the audio cue for Success might make more sense as a globally/generically usable "action complete" sound, which could cover other interactions that come up. This could reduce cognitive load, things to learn, clutter overall.

1. Thoughts on that, and any good reason the sound needs to be very specific to this interaction?

2. I originally had the intention for our existing Save sound to serve as this generic Action Complete (and still do, but not the current shipped version). I'll soon be sending a subtle update to Save, which I believe a) reflects the idea of generic Action Complete a little better and b) addresses/implements some existing feedback for the as-is Save sound.

With the right sounds, how do you feel about Save being a use case of Action Complete, or do you feel it needs to be dedicated?

@AFre100 I think we should use a different sound because that lessens cognitive burden. Save is an action completed by the user or the workbench (autosave) whereas terminal completion is dictated by the shell.

great control flow call out -- thank you @meganrogge for setting the record straight! Totally agree there.

And what do you think about two sounds: 1) global user-initiated success/completion (Save etc) and 2) global system-initiated/controlled success/completion (terminalCommandSucceeded etc)?

@AFre100 what's the timeline here?

@meganrogge I had to take off early today — I'll send an update on Monday :)

@meganrogge In time for May's Insiders would be great — so what would that be, final by May 17?

Yes @AFre100

Hello, can I do something to help moving this forward? Should I fix the conflicts with main?

I've been using my own fork to have this feature for a while and I couldn't live without it now, thx for making it happen 👏 !

@Maximetinu thanks for asking, yes, if you could fix the conflicts, that would help.

@AFre100 what's the status ?

@meganrogge We're on track for a May 17 final delivery for Insiders. Will ping you offline early next week (possibly earlier) to align!

@Maximetinu if you'll fix the conflicts, I have the sound we want to use, so we can likely get this in for May.

@Maximetinu if you'll fix the conflicts, I have the sound we want to use, so we can likely get this in for May.

Done @meganrogge, conflicts resolved! 👌 Let me know if you need anything else, and feel free to make any modifications (you may have to replace the .mp3 by your new sound I suppose). Thanks!

@Maximetinu , I'm unable to push to your branch due to permissions issues. Could you pls fix the conflict, IE accept the incoming sound that I added, so this can be merged?

Thanks!

@Maximetinu , I'm unable to push to your branch due to permissions issues. Could you pls fix the conflict, IE accept the incoming sound that I added, so this can be merged?

@meganrogge done! 👍