-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fullscreen container dimension detection when not directly on body #205884
Fix fullscreen container dimension detection when not directly on body #205884
Conversation
Is there an associated issue that this PR fixes? |
Not at all, it's more a code improvement than a bugfix since no issue can be reproduced in VSCode but it may impact forks and custom builds Should I still create an issue? |
But how can we hard-code a reference to Note that your change impacts not only web but also VS Code for desktop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the issue now, I think having a comment to explain this would be good.
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
If the workbench is rendered in another container than the body, everything works fine except the fullscreen mode.
This PR make the layout service not rely on the parent element size in fullscreen mode as it doesn't make sense and rely on the body size instead.
I don't think it can't break anything as in the browser, the parent element is currently already the main window body